Skip to content

Fix: Path resolution to root in migrations scripts (fixes #3671) #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fix: Path resolution to root in migrations scripts (fixes #3671) #3672

merged 1 commit into from
Apr 15, 2025

Conversation

oliverfoster
Copy link
Member

fixes #3671

Fix

  • Changed from path.join to path.resolve

image

@oliverfoster oliverfoster self-assigned this Apr 14, 2025
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Apr 14, 2025
taylortom
taylortom approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on that one so quickly!

joe-allen-89
joe-allen-89 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit e6d4818 into master Apr 15, 2025
1 of 3 checks passed
@joe-allen-89 joe-allen-89 deleted the issue/3671 branch April 15, 2025 09:06
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Apr 15, 2025
github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
@semantic-release-bot
Chore(release): 5.46.1 [skip ci]
9915684 
## [5.46.1](v5.46.0...v5.46.1) (2025-04-15)

### Fix

* Path resolution to root in migrations scripts (fixes #3671) (#3672) ([e6d4818](e6d4818)), closes [#3671](#3671) [#3672](#3672)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.46.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylortom taylortom taylortom approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cksachdev cksachdev Awaiting requested review from cksachdev

Assignees

@oliverfoster oliverfoster

Labels
bug high priority released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migations path.join vs path.resolve giving C:/path/C:/path.
4 participants
@oliverfoster @taylortom @cahirodoherty-learningpool @joe-allen-89